Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TODOs for unversioned grpc and protobuf #132955

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Jun 6, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Follow-up to #131405.

  • apache-arrow: add TODO for unversioned grpc and protobuf
  • etcd-cpp-apiv3: add TODO for unversioned grpc and protobuf
  • mavsdk: add TODO for unversioned grpc and protobuf

@carlocab carlocab added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jun 6, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Jun 6, 2023
Merged via the queue into Homebrew:master with commit c6b45b4 Jun 6, 2023
@carlocab carlocab deleted the protobuf-grpc-todo branch June 6, 2023 15:36
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants