Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin version used for CI spellchecking to avoid surprise failures after updates #1485

Closed
lbianchi-lbl opened this issue Sep 5, 2024 · 0 comments · Fixed by #1486
Closed

Pin version used for CI spellchecking to avoid surprise failures after updates #1485

lbianchi-lbl opened this issue Sep 5, 2024 · 0 comments · Fixed by #1486
Assignees
@lbianchi-lbl
Labels
Priority:Normal Normal Priority Issue or PR

Comments

@lbianchi-lbl
Copy link
Contributor

We could pin between releases, and on each release cycle update the version and fix any flagged typos. Might be a "best of both worlds" approach so PRs don't fail when typos pushes a new version.

Originally posted by @bpaul4 in #1482 (comment)

Personally I think @bpaul4's suggestion is very sensible, and I suggest we adopt this to avoid having to deal with the concrete possibility of unrelated PRs starting to fail whenever a new version of the typos tool we use for spellchecking in CI is released
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbianchi-lbl lbianchi-lbl

Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pin typos version to latest currently available tag v1.24.5 lbianchi-lbl/idaes-pse
2 participants
@ksbeattie @lbianchi-lbl