Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CtCatchVariable does not include source position of modifiers #1968

Closed
W3D3 opened this issue Apr 18, 2018 · 2 comments · Fixed by #1969
Closed

CtCatchVariable does not include source position of modifiers #1968

W3D3 opened this issue Apr 18, 2018 · 2 comments · Fixed by #1969

Comments

@W3D3
Copy link

W3D3 commented Apr 18, 2018

CtCatchVariable implements the CtModifiable interface and therefore can include modifiers.
For all other classes that implement CtModifiable I found that their SourcePosition is of type DeclarationSourcePosition containing the getters getModifierSourceStart() and getModifierSourceEnd().
This is not the case for the CtCatchVariable.
@W3D3 W3D3 changed the title CtCatchVariable does not include SourceCodePosition of modifiers CtCatchVariable does not include source position of modifiers Apr 18, 2018
@monperrus
Copy link
Collaborator

Thanks for the bug report. What would be the fix to your opinion?

@W3D3
Copy link
Author

W3D3 commented Apr 18, 2018

I would like the CtCatchVariable to also have a DeclarationSourcePosition that can give me the position of its modifiers.

@tdurieux tdurieux mentioned this issue Apr 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(position): fix the position of catch variable tdurieux/spoon
2 participants
@monperrus @W3D3