refactor: CtFormalTypeDeclarer extends CtTypeMember #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what's the purpose? |
|
The code which collects formal type arguments of declaring types is little bit simpler if CtFormalTypeDeclarer extends CtTypeMember, because it is so. CtFormalTypeDeclarer already extends CtFormalTypeDeclarer, but it is not declared in model. But if you have any reason why it is not good idea then close this PR. I have no problem with that. |
|
CtFormalTypeDeclarer already extends CtFormalTypeDeclarer
what do you mean exactly? :-)
|
|
That all existing implementations of |
|
Then I'm fine to merge this one. If somebody disagrees, drop a comment :-)
|
|
look good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What about this small change in spoon model?