review: feature ExecutableReferenceFilter #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvojtechovsky
force-pushed
the
featExecutableReferenceFilter
branch
from
dde7691
to
429e254
Compare
pvojtechovsky
force-pushed
the
featExecutableReferenceFilter
branch
from
429e254
to
a553817
Compare
pvojtechovsky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
ExecutableReferenceFilterprovides fast matching for allCtExecutableReferences of defined set ofCtExecutables.It is used to found all invocations of
CtExecutables in future method refactoring PRs.This filter is much faster and has different contract then legacy InvocationFilter, which
If you do not like contract of ExecutableReferenceFilter, then optional solution would be to refactor legacy InvocationFilter by way it can be configured to support contract of this ExecutableReferenceFilter - to return (if configured so) exact (not overriding) invocations of more then one executable.