review fix: contract CtAnnotation and array of values #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 78a176f.
| * Name of searched value. | ||
| * @return the value expression or null if not found. | ||
| */ | ||
| @PropertyGetter(role = VALUE) |
There was a problem hiding this comment.
Please add @Derived to this method... otherwise the metamodel based code will be confused.
| CtArrayTypeReference typeReference2 = this.getFactory().createArrayTypeReference(); | ||
| typeReference2.setComponentType(ctExpression.getType().clone()); | ||
| newArray.setType(typeReference); | ||
| newArray.addElement(ctExpression); |
There was a problem hiding this comment.
newArray.addElement(ctExpression.clone());
clone is missing
surli
changed the title
monperrus
reviewed
Apr 3, 2018
|
|
||
| if (ctExpression instanceof CtLiteral) { | ||
| CtTypeReference typeReference = this.getAnnotationType(); | ||
| CtType type = typeReference.getDeclaration(); |
|
I have a doubt about the name Does this method always return a CtNewArray? |
only if it respects some conditions (it's the only CtLiteral value and the annotation should return an array) else it returns the same value as |
|
what about getWrappedValue?
|
|
API changes: 1 (Detected by Revapi) Old API: fr.inria.gforge.spoon:spoon-core:jar:6.3.0-20180404.073823-36 / New API: fr.inria.gforge.spoon:spoon-core:jar:6.3.0-SNAPSHOT
|
|
Thanks Simon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix the contract defined after discussion in #1928