Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help: fix: always create new type reference for primitive type #1940

Merged

Conversation

pvojtechovsky
Copy link
Collaborator

The type references to primitive types like void sometime copied the source position from another type reference. See test for details.

@pvojtechovsky
Copy link
Collaborator Author

This PR actually fails on AnnotationTest#testSpoonSpoonResult. I would say that this test is wrong. Hard to say for me what was origin intent.

@surli @monperrus please have a look at it and fix the test or explain me what was the idea, so I can fix it.

@pvojtechovsky pvojtechovsky changed the title fix: always create new type reference for primitive type help: fix: always create new type reference for primitive type Mar 31, 2018
@monperrus
Copy link
Collaborator

it was a fix, see #970.

however, like you, when looking at the test and the spooned code, it's unclear.

I would suggest to go ahead, change the assertion!(and we'll see if dropwizard fails again, and we'll try to better fix it)

@pvojtechovsky
Copy link
Collaborator Author

I guess the assertion was intended for the annotated field. So I changed it this way.

I am finished here. It is ready for merge from my point of view

@monperrus monperrus merged commit 7811737 into INRIA:master Apr 3, 2018
@monperrus
Copy link
Collaborator

Thanks Pavel.

@surli surli mentioned this pull request Jun 25, 2018
@pvojtechovsky pvojtechovsky deleted the fixReferenceBuilderOfPrimitiveTypes branch September 1, 2018 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants