Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: feat: ChangeCollector listens on changes and remembers them #1941

Merged
merged 2 commits into from
Apr 6, 2018
Merged

review: feat: ChangeCollector listens on changes and remembers them #1941

merged 2 commits into from
Apr 6, 2018

Conversation

pvojtechovsky
Copy link
Collaborator 

ChangeCollector changeCollector = new ChangeCollector().attachTo(f.getEnvironment());

//.. do some changes on the model..

Set<CtRole> changedAttributes = changeCollector.getChanges(anElement);

@tdurieux
Copy link
Collaborator

tdurieux commented Apr 2, 2018

That is very nice solution

@monperrus
Copy link
Collaborator

nice!

do you work on the TODO before merging? otherwise it's cleaner to remove them.

@pvojtechovsky pvojtechovsky mentioned this pull request Apr 2, 2018
Closed
@pvojtechovsky pvojtechovsky changed the title review: feat: ChangeCollector listens on changes and remembers them postponed: feat: ChangeCollector listens on changes and remembers them Apr 5, 2018
@pvojtechovsky
Copy link
Collaborator Author

pvojtechovsky commented Apr 5, 2018 •
edited
Loading

this PR is waiting for result of discussion in #1943

@pvojtechovsky
Copy link
Collaborator Author

So that was last change here. It is ready for merge.

@pvojtechovsky pvojtechovsky changed the title postponed: feat: ChangeCollector listens on changes and remembers them review: feat: ChangeCollector listens on changes and remembers them Apr 5, 2018
@monperrus monperrus merged commit 252d525 into INRIA:master Apr 6, 2018
@pvojtechovsky pvojtechovsky deleted the feaChangeCollector branch April 7, 2018 06:24
@surli surli mentioned this pull request Jun 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvojtechovsky @tdurieux @monperrus