review feat: Enable comments by default #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The comment was not enable for performance reasons. |
Do we have an idea about the perf difference on a large code base? |
|
We need to read again all the Java files. |
surli
changed the title
|
I'm rather OK for this new default behavior. |
surli
changed the title
surli
changed the title
|
THanks. We have to prepare a really good changelog with all the non-bacward compatible changes such as this one. |
This was referenced Jun 20, 2018
seintur
reviewed
Sep 10, 2019
| if (jsapActualArgs.getBoolean("enable-comments")) { | ||
| Launcher.LOGGER.warn("The option --enable-comments (-c) is deprecated as it is now the default behaviour in Spoon."); | ||
| } else { | ||
| Launcher.LOGGER.warn("Spoon now parse by default the comments. Consider using the option --disable-comments if you want the old behaviour."); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal to change a default behaviour in Spoon: until now, the default was to not take into account the comments.
I assume this behaviour was used because the comments were not properly parsed then. But I think it's not the case anymore and we got more users using Spoon for parsing comments: very recently we got a question on Stackoverflow linked to that: https://stackoverflow.com/questions/50780598/how-to-get-comments-using-spoon/ and I know we also got issues related to that.
So in the same way we decided to use
noclasspathmode by default, I propose that we parse comments by default. WDYT?