Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(position): CompoundSourcePosition extends SourcePosition #2115

Merged
merged 2 commits into from
Jun 28, 2018

Conversation

pvojtechovsky
Copy link
Collaborator

first baby step to fix #2055

  • CompoundSourcePosition extends SourcePosition
  • DeclarationSourcePosition extends CompoundSourcePosition
  • part of fields and code of DeclarationSourcePositionImpl was moved to CompoundSourcePositionImpl

@surli
Copy link
Collaborator

surli commented Jun 27, 2018

I assume this is the first one to review before #2113 right? is it ready?

import spoon.reflect.cu.SourcePosition;

/**
* This interface represents the position of a program element in a source file.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The javadoc here is exactly the same that for DeclarationSourcePosition. Could you edit one of those Javadoc to explicit the differences between the interfaces?

@pvojtechovsky
Copy link
Collaborator Author

is it ready?

yes, I am done here.

@spoon-bot
Copy link
Collaborator

API changes: 1 (Detected by Revapi)

Old API: fr.inria.gforge.spoon:spoon-core:jar:6.3.0-20180627.172809-176 / New API: fr.inria.gforge.spoon:spoon-core:jar:6.3.0-SNAPSHOT

Method was added to an interface.
Old none
New method CoreFactory#createCompoundSourcePosition(CompilationUnit, int, int, int, int, .Array)
Breaking binary: non_breaking,

@monperrus monperrus merged commit 90b7ed2 into INRIA:master Jun 28, 2018
@pvojtechovsky pvojtechovsky deleted the feaCompoundSrcPos branch June 28, 2018 09:20
@surli surli mentioned this pull request Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source position and type cast and brackets
4 participants