fix: position of nested type arguments like List<List<?>> #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is ready for merge from my point of view |
tdurieux
reviewed
Jun 30, 2018
| @@ -126,6 +125,10 @@ public void testPositionParameterTypeReference() throws Exception { | |||
| CtTypeReference<?> field3Type = foo.getField("field3").getType(); | |||
| //this probably points to an bug in JDT. But we have no workaround in Spoon, which handles spaces and comments too | |||
| assertEquals("List<T // */ >\n\t/*// */>", contentAtPosition(classContent, field3Type.getPosition())); | |||
|
|
|||
| CtTypeReference<?> field4Type = foo.getField("field4").getType(); | |||
| //this probably points to an bug in JDT. But we have no workaround in Spoon, which handles spaces and comments too | |||
There was a problem hiding this comment.
Did you copy the comment on purpose?
There was a problem hiding this comment.
thanks for pointing to that. It was not intentional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix of another problem found by Sniper mode tests