fix: Remove incorrect implicitness for package reference #3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monperrus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3336
This is an attempt to fix the problem discussed in the aforementioned issue. I don't know why the package reference is to implicit where it is, but removing it with edf9700 fixed my problems. This also causes some changes in generated code, so I had to update
testGeneratedSpoonifyCodewith 8acb899.I really don't know if this PR is reasonable. It works for me and does not appear to cause any breakage other than
testGeneratedSpoonifyCode. Accidentally setting an explicit reference to implicit is in my opinion much worse than the other way around, as the former can cause compile errors, and has done so for me multiple times.