Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always allow null parameter for setters. #694

Merged
merged 1 commit into from
Jun 14, 2016
Merged

Always allow null parameter for setters. #694

merged 1 commit into from
Jun 14, 2016

Conversation

GerardPaligot
Copy link
Contributor

No description provided.

@monperrus
Copy link
Collaborator

still failing?

@GerardPaligot
Copy link
Contributor Author

Think to add a test case which call the setter with null argument.

@GerardPaligot GerardPaligot changed the title feat(parent): Protect setParent() in setters. Always allow null parameter for setters. Jun 13, 2016
@GerardPaligot
Copy link
Contributor Author

@monperrus PR ok for me.

@monperrus monperrus merged commit cf1204d into INRIA:master Jun 14, 2016
@GerardPaligot GerardPaligot deleted the feat_parent branch June 14, 2016 19:03
@tdurieux tdurieux mentioned this pull request Jun 24, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GerardPaligot @monperrus