Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: doesn't adjust position for implicit source code #696

Merged
merged 1 commit into from
Jun 13, 2016
Merged

fix: doesn't adjust position for implicit source code #696

merged 1 commit into from
Jun 13, 2016

Conversation

petitpre
Copy link
Contributor

@petitpre petitpre commented Jun 9, 2016

No description provided.

@monperrus
Copy link
Collaborator

do you have a test case? Thanks!

@petitpre
Copy link
Contributor Author

No, but you can contribute :p

This modification only remove warning when the pretty printer cannot adjust position of implicit elements...

@monperrus
Copy link
Collaborator

We don't have a single assertion about the line-preserving mode, it
would be great to have some.

If you use this mode, you should be able to write a nice test :-)

@GerardPaligot GerardPaligot merged commit c8282ff into INRIA:master Jun 13, 2016
@GerardPaligot
Copy link
Contributor

Thanks @petitpre for this PR.

@tdurieux tdurieux mentioned this pull request Jun 24, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petitpre @monperrus @GerardPaligot