Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move loading of File Permissions out of FilePermissionsProvider #272

Closed
ekraffmiller opened this issue Jan 2, 2024 · 0 comments · Fixed by #290
Closed

Move loading of File Permissions out of FilePermissionsProvider #272

ekraffmiller opened this issue Jan 2, 2024 · 0 comments · Fixed by #290
Assignees
@ekraffmiller
Labels
bug Something isn't working pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 10 A percentage of a sprint. 7 hours. SPA: Dataset page (View) UI Tasks related to the user interface (UI) or frontend development

Comments

@ekraffmiller
Copy link
Contributor

ekraffmiller commented Jan 2, 2024 •
edited
Loading

There are still some timing errors happening when the File Permissions are retrieved in the FilePermissionsProvider, so we will move this logic to the main file loading function in FileJSDaverseRepository.ts. This will also be consistent with how dataset permissions are loaded in the View Dataset use case.
@ekraffmiller ekraffmiller added bug Something isn't working pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows SPA: Dataset page (View) UI Tasks related to the user interface (UI) or frontend development Size: 10 A percentage of a sprint. 7 hours. labels Jan 2, 2024
@ekraffmiller ekraffmiller self-assigned this Jan 8, 2024
@ekraffmiller ekraffmiller mentioned this issue Jan 26, 2024
Merged
@cmbz cmbz mentioned this issue Mar 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ekraffmiller ekraffmiller

Labels
bug Something isn't working pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 10 A percentage of a sprint. 7 hours. SPA: Dataset page (View) UI Tasks related to the user interface (UI) or frontend development
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

272 move filepreview permissions IQSS/dataverse-frontend
1 participant
@ekraffmiller