Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Loading' text briefly appears when navigating from Home Page to View Dataset Page #279

Closed
ekraffmiller opened this issue Jan 10, 2024 · 1 comment Β· Fixed by #287
Closed
Assignees
Labels
bug Something isn't working pm.GREI-d-1.7.1 NIH, yr1, aim7, task1: Research & architecture for separating backend and frontend pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. UI Tasks related to the user interface (UI) or frontend development

Comments

@ekraffmiller
Copy link
Contributor

ekraffmiller commented Jan 10, 2024

From Guillermo's QA comments, steps to reproduce:

I have done different tests, which I share below with videos and the steps to reproduce.

I'm using emojis (🚨 and βœ…) to explain if the behavior is working as expected or if revision is required.

TEST 1 - Create first dataset from empty installation

creatingvideo.mov

Steps:

  1. Dataverse is empty, so I log in via JSF to create a data set.
  2. I create a test dataset through JSF
  3. I navigate to the JSF home page to see how the created dataset card is displayed in the list.
  4. βœ… I navigate to the SPA home page to verify that the new dataset is displayed in the list with the same appearance as in JSF.
  5. 🚨 I click the dataset in the list and navigate to the dataset page. I see that when navigating, instead of directly opening the dataset page, it goes through an intermediate page where a text "loading" appears (very quickly, but noticeable). See the following screenshot:
LOADINGPAGE
  1. βœ… The dataset page correctly displays the requested dataset

Originally posted by @GPortas in #274 (review)

@ekraffmiller ekraffmiller added bug Something isn't working UI Tasks related to the user interface (UI) or frontend development pm.GREI-d-1.7.1 NIH, yr1, aim7, task1: Research & architecture for separating backend and frontend pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows labels Jan 10, 2024
@ekraffmiller ekraffmiller changed the title 'Loading text briefly appears when navigating from Home Page to View Dataset Page 'Loading' text briefly appears when navigating from Home Page to View Dataset Page Jan 10, 2024
@M27Mangan
Copy link

I think the loading functionality should appear lower in the component hierarchy, possibly including a skeleton component. In my opinion there should be some visual communication to the user that there is data being fetched and the website is actively working. Attempting to recreate every aspect of the JSF site (including the not ideal ones) would be counterproductive I think. Happy to take this item and work with stakeholders.

@MellyGray MellyGray added the Size: 3 A percentage of a sprint. 2.1 hours. label Jan 17, 2024
@MellyGray MellyGray self-assigned this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pm.GREI-d-1.7.1 NIH, yr1, aim7, task1: Research & architecture for separating backend and frontend pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. UI Tasks related to the user interface (UI) or frontend development
Projects
None yet
3 participants