Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Query Param in Home Page dataset list pagination #280

Closed
ekraffmiller opened this issue Jan 10, 2024 · 1 comment · Fixed by #284
Closed

Use Query Param in Home Page dataset list pagination #280

ekraffmiller opened this issue Jan 10, 2024 · 1 comment · Fixed by #284
Assignees
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) UI Tasks related to the user interface (UI) or frontend development

Comments

@ekraffmiller
Copy link
Contributor

From Guillermo' QA comments, steps to reproduce:

TEST 4 - Pagination: Back button and URL page query param

🚨

In JSF, a query parameter is added to the URL to indicate the results page you are on. I think we should continue to support this. It is useful for scenarios like the following:

  • When you have navigated to a new result page, by clicking on the browser's back button you navigate to the previously selected page.

  • With the query param you are also able to share a URL that leads directly to a particular page on the home page.

You can see in the following video how, by not adding the query parameter, the back button navigates to the page before reaching the home page.

paginationtest2.mov

Originally posted by @GPortas in #274 (review)

@ekraffmiller ekraffmiller added UI Tasks related to the user interface (UI) or frontend development pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows labels Jan 10, 2024
@pdurbin
Copy link
Member

pdurbin commented Jan 10, 2024

I'm glad I didn't have to ask for continued support for this. 😄 On the JSF side I made sure the query parameters are present in the URL so people can bookmark or send links around or even hack on the URL. I think they're useful.

JSF has a limitation where you can't have the same parameter over and over. However, in the Search API we repeat fq as often as we like. I imagine the SPA would work like the Search API.

@MellyGray MellyGray added the Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) label Jan 17, 2024
@MellyGray MellyGray self-assigned this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) UI Tasks related to the user interface (UI) or frontend development
Projects
None yet
3 participants