Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SPA development proposal for Q2 #314

Closed
GPortas opened this issue Feb 15, 2024 · 8 comments
Closed

Create SPA development proposal for Q2 #314

GPortas opened this issue Feb 15, 2024 · 8 comments
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 30 A percentage of a sprint. 21 hours. (formerly size:33)

Comments

@GPortas
Copy link
Contributor

GPortas commented Feb 15, 2024

Overview of the Feature Request

Just like we did with the beta proposal for the community day, we need to write a new proposal for the next months (Q2). This document will highlight the new features the SPA will include in the upcoming months. This document will be shared with the community at the community day.

What kind of user is the feature intended for?

All of them

What inspired the request?

  • Discussion with the team

What existing behavior do you want changed?

N/A

Any brand new behavior do you want to add to Dataverse?

N/A

Any open or closed issues related to this feature request?

N/A

@GPortas GPortas added Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows labels Feb 15, 2024
@GPortas GPortas self-assigned this Feb 20, 2024
@GPortas
Copy link
Contributor Author

GPortas commented Feb 22, 2024

Waiting for some initial feedback from the team.

@GPortas GPortas added Waiting and removed Waiting labels Feb 26, 2024
@GPortas
Copy link
Contributor Author

GPortas commented Feb 26, 2024

Waiting for feedback from the team.

@GPortas GPortas removed the Waiting label Feb 26, 2024
@GPortas GPortas removed their assignment Feb 26, 2024
@pdurbin
Copy link
Member

pdurbin commented Feb 27, 2024

I just read through the doc and it looks good. I left a comment about what's included under "write operations".

Also, I didn't want to junk up the doc with "I agree" but I'm glad we're considering NOT having file upload as part of dataset creation. I never use it. I like the idea of the dataset having a database id before I upload files. 😄 Plus, apart from creating datasets with BagIT (I think), we don't easily offer this "create and upload" functionality via the API. (If we do offer it in the SPA, perhaps the API gets a new, testable feature.)

I'll leave this is in Ready for Review to give others a chance.

@jggautier
Copy link

Wow, thanks @pdurbin for mentioning that the removal of file upload from the dataset creation is being considered as part of this. I had assumed that this proposal would be similar to the beta proposal and changes like this wouldn't be proposed here, so I wasn't planning on following it very closely or contributing much.

I wonder if others on the team haven't chimed in because they assume the same.

@ekraffmiller
Copy link
Contributor

I also like the idea of making the file upload a separate step, but maybe we need to consider more the user experience? @jggautier, do you think this would be missed by users?

@landreev
Copy link

I've been long in favor of dropping file upload from create, yes.
Whether it would be missed by users - there's one very efficient way to find out for sure.
It would 100% simplify the workflow and reduce the number of places where things can go wrong.

@jggautier
Copy link

Hi @ekraffmiller. Yeah I think different types of users will notice it. Not sure if they'll wish it was there 🤔

Sorry, my comment was more about the nature of this proposal compared to the beta one and whether others on the team were aware of how it's different and how it affects what kind of work would be involved and who should be involved. The great conversation in the dv-tech Slack channel yesterday is more along the lines of what I was getting at.

@GPortas
Copy link
Contributor Author

GPortas commented Mar 4, 2024

Closed, as the proposal has been reviewed and refined based on team feedback.

@GPortas GPortas closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 30 A percentage of a sprint. 21 hours. (formerly size:33)
Projects
None yet
Development

No branches or pull requests

5 participants