Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement lazy loading #381

Open
g-saracca opened this issue Apr 22, 2024 · 0 comments · May be fixed by #512
Open

Implement lazy loading #381

g-saracca opened this issue Apr 22, 2024 · 0 comments · May be fixed by #512
Labels
FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) GREI Re-arch GREI re-architecture-related Original size: 10 performance Improve performance of an existing feature Size: 10 A percentage of a sprint. 7 hours. Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) SPA.Q3 Not related to any specific Q3 feature SPA

Comments

@g-saracca
Copy link
Contributor

g-saracca commented Apr 22, 2024

It would be very beneficial to improve the performance of the application to load the different pages in a lazy way.
This could just be done at the Router level with lazy imports

This way, if the user only visits the Collections page, for instance, only the javascript needed for that view will be loaded and not the javascript of the whole application.

Update:

After investigating why the Suspense fallback (spinner) component for the dynamically loaded modules was rendering more than once, it was discovered that it was due to the “useTranslation” hook that was triggering the Suspense when loading a locale json after the page was loaded.
See documentation info.
Screen Shot 2024-09-25 at 10 30 41

This is currently happening on Beta environment so this will fix this also.

@g-saracca g-saracca added Size: 10 A percentage of a sprint. 7 hours. pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows performance Improve performance of an existing feature labels Apr 22, 2024
@g-saracca g-saracca self-assigned this Apr 29, 2024
@g-saracca g-saracca added Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) GREI Re-arch GREI re-architecture-related SPA and removed Size: 10 A percentage of a sprint. 7 hours. pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows labels Sep 25, 2024
@g-saracca g-saracca removed their assignment Sep 25, 2024
@GPortas GPortas added SPA.Q3 Not related to any specific Q3 feature FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) Original size: 30 labels Sep 25, 2024
@g-saracca g-saracca self-assigned this Sep 26, 2024
@g-saracca g-saracca added Original size: 10 Size: 10 A percentage of a sprint. 7 hours. and removed Original size: 30 labels Sep 30, 2024
@g-saracca g-saracca linked a pull request Sep 30, 2024 that will close this issue
@g-saracca g-saracca removed their assignment Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) GREI Re-arch GREI re-architecture-related Original size: 10 performance Improve performance of an existing feature Size: 10 A percentage of a sprint. 7 hours. Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) SPA.Q3 Not related to any specific Q3 feature SPA
Projects
None yet
2 participants