Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Dataset: email validation does not match validation in the Dataverse API #393

Closed
ekraffmiller opened this issue May 1, 2024 · 2 comments · Fixed by #402
Closed
Labels
bug Something isn't working pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 10 A percentage of a sprint. 7 hours.

Comments

@ekraffmiller
Copy link
Contributor

What steps does it take to reproduce the issue?
Go to Create Dataset form, in Point of Contact email, enter an email address that ends with a non-tld string, for example, 'ellen@test.e' and all the other required fields

  • When does this issue occur?
    When submitting Create Dataset form
  • Which page(s) does it occur on?
    Create Dataset
  • What happens?
    It shows an Alert message about a validation error, but it doesn't say what the error is, and the email field isn't highlighted
Screenshot 2024-05-01 at 3 17 17 PM

In the Network tab, the create fails with 403 and this error message:

{
    "status": "ERROR",
    "message": "Validation Failed: Point of Contact E-mail ellen@test.e  is not a valid email address. (Invalid value:edu.harvard.iq.dataverse.DatasetFieldValueValue[ id=null ]).java.util.stream.ReferencePipeline$3@626c7975"
}
@ekraffmiller ekraffmiller added pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows bug Something isn't working labels May 1, 2024
@pdurbin
Copy link
Member

pdurbin commented May 1, 2024

Just a couple details from Slack:

@GPortas GPortas added the Size: 10 A percentage of a sprint. 7 hours. label May 8, 2024
@g-saracca g-saracca self-assigned this May 13, 2024
@g-saracca
Copy link
Contributor

Waiting for Dynamic Multiple Fields PR to be merged.
In the above-mentioned pr, there are some changes and refactor that could be better to wait until keep working on this issue to avoid lots of merging conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 10 A percentage of a sprint. 7 hours.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants