From ac232c83f8374e2d3c6911badb4f994df8b498fd Mon Sep 17 00:00:00 2001
From: Michael Heppler <mheppler@hmdc.harvard.edu>
Date: Thu, 2 Aug 2018 12:36:32 -0400
Subject: [PATCH] Fixed msg rendering for upload pg that has a package file,
 plus panel default open view for rsync only. [ref #4610]

---
 src/main/webapp/editFilesFragment.xhtml | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/src/main/webapp/editFilesFragment.xhtml b/src/main/webapp/editFilesFragment.xhtml
index 524a1d99c5e..01ca5a1b30d 100644
--- a/src/main/webapp/editFilesFragment.xhtml
+++ b/src/main/webapp/editFilesFragment.xhtml
@@ -20,8 +20,7 @@
         </ul>
         <div class="ui-tabs-panels">
             <div aria-hidden="false" role="tabpanel" class="ui-tabs-panel ui-widget-content ui-corner-bottom" id="datasetForm:tabView:dataFilesTab">
-                
-                
+                <!-- Create dataset workflow info msg + user guide link -->
                 <div jsf:rendered="#{createDataset}">
                     <p class="help-block">
                         <h:outputFormat value="#{bundle['dataset.message.uploadFiles.message']}" escape="false">
@@ -242,7 +241,8 @@
                             </h4>
                         </div>
 
-                        <div id="collapseRsync" class="panel-collapse collapse" role="tabpanel" aria-labelledby="headingRsync">
+                        <!-- NOTE: conditional logic for 'in' style class opens the rsync panel if HTTP is off, but isn't scalable when a third upload mode is added -->
+                        <div id="collapseRsync" class="panel-collapse collapse #{!settingsWrapper.HTTPUpload ? 'in' : ''}" role="tabpanel" aria-labelledby="headingRsync">
                             <div class="panel-body">
                                 <ui:fragment rendered="#{createDataset}">
                                     <p class="help-block">
@@ -256,12 +256,18 @@
                                             <h:outputText class="text-danger" value=" #{bundle['file.rsyncUpload.filesExist']}" escape="false"/>
                                         </p>
                                     </ui:fragment>
-                                    <ui:fragment rendered="#{!EditDatafilesPage.isHasRsyncScript() and empty EditDatafilesPage.fileMetadatas}">
+                                    <ui:fragment rendered="#{!EditDatafilesPage.isHasRsyncScript() and (empty EditDatafilesPage.fileMetadatas and empty DatasetPage.workingVersion.hasPackageFile)}">
                                         <p class="help-block">
                                             <span class="glyphicon glyphicon-warning-sign text-danger"></span>
                                             <h:outputText class="text-danger" value=" #{bundle['file.rsyncUpload.noScriptAvailable']}" escape="false"/>
                                         </p>
                                     </ui:fragment>
+                                    <ui:fragment rendered="#{!EditDatafilesPage.isHasRsyncScript() and (empty EditDatafilesPage.fileMetadatas and DatasetPage.workingVersion.hasPackageFile)}">
+                                        <p class="help-block">
+                                            <span class="glyphicon glyphicon-warning-sign text-danger"></span>
+                                            <h:outputText class="text-danger" value=" #{bundle['file.rsyncUpload.filesExist']}" escape="false"/>
+                                        </p>
+                                    </ui:fragment>
                                     <ui:fragment rendered="#{EditDatafilesPage.isHasRsyncScript() and empty EditDatafilesPage.fileMetadatas}">
                                         <p class="help-block">
                                             <span class="glyphicon glyphicon-info-sign"></span>