Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions: Roles page shows users, roles and assignments from parent dv but cannot interact with them. #1052

Closed
kcondon opened this issue Nov 2, 2014 · 5 comments
Assignees
Labels
Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner

Comments

@kcondon
Copy link
Contributor

kcondon commented Nov 2, 2014

The current roles page shows pete and guest as manager and guest of root with revoke button active, though it does nothing. Those roles are also available in the assignment area though again they do nothing.

@kcondon kcondon added UX & UI: Design This issue needs input on the design of the UI and from the product owner Priority: Medium Type: Bug a defect labels Nov 2, 2014
@kcondon kcondon added this to the Beta 8 - Dataverse 4.0 milestone Nov 2, 2014
@kcondon kcondon changed the title Permissions: Roles page shows use roles and assignments from parent dv but cannot interact with them. Permissions: Roles page shows users, roles and assignments from parent dv but cannot interact with them. Nov 3, 2014
@scolapasta
Copy link
Contributor

I think the issue was that, these were assignments inherited from the parent and so you did not have permission to revoke. I went ahead and wired up the inherit and also added permission checks to display the revoke and Edit buttons.

@kcondon
Copy link
Contributor Author

kcondon commented Nov 4, 2014

OK, this is better:
if inherit permissions is not checked, there is no reference to any other roles outside of this dv.

However, if it is checked,
in the user, role assignment select box the dv manager parent role and the guest parent role are still listed when they can't be assigned here.

Also, though it correctly lists the parent manager assigned to the parent dv, it might be helpful in the area where the revoke button was to say inherited. Also, instead of listing the object as the parent dv, it should be this dv since this is the context.

@kcondon kcondon assigned scolapasta and unassigned kcondon Nov 4, 2014
@scolapasta
Copy link
Contributor

Discussed with Kevin - seems like it's not as much functional issues left, rather how the info is conveyed. Will revisit once we clean up the roles and have that discussion.

@scolapasta
Copy link
Contributor

Passing back to QA.

When you inherit, you can use the roles from your parent.

I reomved the object column and added where the rle comes from (if not that level) in () after the role. I think that's more obvious.

These pages still need Mike cleanup, but passing this back to QA as I don't think their are any functional issues here. There is a separate issue #88 for the UI, if we want to clean up the way we present the info.

@kcondon
Copy link
Contributor Author

kcondon commented Nov 13, 2014

OK, revoke button not seen on inherited roles. I still think there needs to be some improved descriptions here. Will follow up with Mike on ticket #88.

@kcondon kcondon closed this as completed Nov 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

2 participants