-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permissions: Roles page shows users, roles and assignments from parent dv but cannot interact with them. #1052
Comments
I think the issue was that, these were assignments inherited from the parent and so you did not have permission to revoke. I went ahead and wired up the inherit and also added permission checks to display the revoke and Edit buttons. |
OK, this is better: However, if it is checked, Also, though it correctly lists the parent manager assigned to the parent dv, it might be helpful in the area where the revoke button was to say inherited. Also, instead of listing the object as the parent dv, it should be this dv since this is the context. |
Discussed with Kevin - seems like it's not as much functional issues left, rather how the info is conveyed. Will revisit once we clean up the roles and have that discussion. |
Passing back to QA. When you inherit, you can use the roles from your parent. I reomved the object column and added where the rle comes from (if not that level) in () after the role. I think that's more obvious. These pages still need Mike cleanup, but passing this back to QA as I don't think their are any functional issues here. There is a separate issue #88 for the UI, if we want to clean up the way we present the info. |
OK, revoke button not seen on inherited roles. I still think there needs to be some improved descriptions here. Will follow up with Mike on ticket #88. |
The current roles page shows pete and guest as manager and guest of root with revoke button active, though it does nothing. Those roles are also available in the assignment area though again they do nothing.
The text was updated successfully, but these errors were encountered: