Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files: Select a File to Upload button only works if click on the + sign #152

Closed
eaquigley opened this issue Jul 9, 2014 · 2 comments
Closed
Assignees
Labels
Type: Bug a defect

Comments

@eaquigley
Copy link
Contributor


Author Name: Kevin Condon (@kcondon)
Original Redmine Issue: 3562, https://redmine.hmdc.harvard.edu/issues/3562
Original Date: 2014-02-25
Original Assignee: Elda Sotiri


From 2/21/14 Pilot Test Meeting Notes

Select a File to Upload button: need to confirm if ability to only click on the + sign in the button in order to upload is an issue on other browsers

@eaquigley
Copy link
Contributor Author


Original Redmine Comment
Author Name: Leonid Andreev (@landreev)
Original Date: 2014-02-28T17:57:49Z


OK, strictly speaking, it wasn't "if click on the + sign" - you could click anywhere on the button, as long as it wasn't close to the upper edge of the button. Safari was the affected browser.

It appears that this was the side effect of the following in the p:fileUpload element representing the button:

style="margin-top:.5em;"

removing this style attribute has fixed the issue.
However this should probably be run by Mike (there was probably a reason that style was there... - although the button seems to be looking OK, both in Firefox and Safari as of now).

@eaquigley eaquigley added this to the Dataverse 4.0: Beta 1 milestone Jul 9, 2014
@eaquigley
Copy link
Contributor Author


Original Redmine Comment
Author Name: Elda Sotiri (@esotiri)
Original Date: 2014-03-05T15:47:39Z


Select a File to Upload button seems to be working ok on:
mac: chrome, firefox, safari
windows 7: ie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect
Projects
None yet
Development

No branches or pull requests

2 participants