Show Access Conditions/Restrictions for Files

[adam3smith]

This is to some extent a duplicate of #2872 but @pdurbin encouraged me to open a new ticket, so here goes.

User Story 1: As a potential data user/downloader, I want to be able to tell the access conditions for any given file as quickly as possible, ideally without even having to log in to dataverse.

User Story 2: As a repository, I want all of our files restricted, but most of them available to all registered users. I want potential users, who are not logged in, to be able to see that they only need to create an account to access a given file.

Current situation: I can see that a file is restricted, but there is no way for me to tell what the access restrictions are. Even on clicking "Request Access" I don't get a pop-up informing me what I'll actually have to do to get access, but it just sends the access request.

Proposal: My preferred solution would be to have the terms of access shown as part of the file metadata:

If that's not an option, then showing them on clicking Request Access (as per #2872) would do for us, but is a second best.

[mheppler]

Reviewed this issue and the closed #2872 issue with @TaniaSchlatter. The popup to display the Terms of Access is straight forward and ready for development. We are already displaying the Terms of Access properly when the Guestbook is enable. (See screenshot.)

For the user stories submitted by @adam3smith, we will continue to review those, to make sure we're delivering the requested features. The "Terms" tab of the dataset page has a "Terms of Access" panel which displays all the requested information to users (without requiring log in).

[pdurbin]

Seeing "Guest" in the screenshot above (thanks, @mheppler ) reminds me that there is an open issue at #3628 to reconsider whether we should continue to pre-populate "Name" with "Guest" or not. If we're fine with the existing behavior, we could simply close #3628.

[djbrooke]

Hey @adam3smith - we're going to push through #2872 since it's small and the designs are already set. We'll revisit these changes in terms (heh) of upcoming changes to request workflows in 5.0.

[pdurbin]

Related: File Page needs a Term Tab #4391

[adam3smith]

Closing this in favor of #4391. Since the improved request access dialog already implements part of this, displaying relevant terms in the file landing page -- whether that's in the metadata or in a separate tab is all that's left to do here.