Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataverse Theme - Child dataverses should not automatically inheret theme logo, tagline, text/background colors #4190

Closed
mheppler opened this issue Oct 11, 2017 · 5 comments

Comments

@mheppler
Copy link
Contributor

mheppler commented Oct 11, 2017

When creating a new dataverse under the root, the logo image, tagline and text/background colors of the root's theme are inherited by this new dataverse. That functionality was intended for use cases when creating a new child dataverse under my own dataverse, not in use cases where I am just a general user creating a new dataverse for the first time under the root.

For an example, I took a screenshot of a new dataverse that I was creating under the Harvard Dataverse, as a researcher affiliated with Yale University.

screen shot 2017-10-11 at 4 40 51 pm

A potential solution would be to inherit the theme logo and text/background colors ONLY IF the user has the admin permissions to that parent dataverse. If you don't, then you get the default colors and no logo.

@TaniaSchlatter
Copy link
Member

TaniaSchlatter commented Oct 11, 2017

So this means:

  • there are no Harvard Logos and gray boxes for Dataverses under the root.
  • new dataverses only have a logo and custom background color if they are created by someone with admin permissions for the parent dataverse.
    If so, sounds good.

@mheppler
Copy link
Contributor Author

@TaniaSchlatter -- just to clarify one of your points, the default grey (#f3f3f1) theme header background color is a setting that would be an additional changed. We discussed the possibility of doing this, but wasn't sure if that was finalized or not. A suggestion you had made was no background color, or white (#ffffff).

@TaniaSchlatter
Copy link
Member

Suggestion is for white. Please see the example screen shots attached.
custom_dataverse_page
custom_newdataverse

This would not affect customizations:
custom_journal

@mheppler mheppler changed the title Dataverse Theme - Should all child dataverses to the root inheret logo and text/background colors? Dataverse Theme - Child dataverses should not automatically inheret theme logo, tagline, text/background colors Oct 12, 2017
@sbarbosadataverse
Copy link

sbarbosadataverse commented Oct 12, 2017 via email

@mheppler
Copy link
Contributor Author

I am closing this issue in favor of two new issues due to this issue getting wider in scope than originally intended.

The first issue is the original bug that I was trying to report, but didn't due with the correct information. That has been clarified in the following issue, Add Dataverse - Root's theme logo mistakenly displayed when creating dataverse #4198.

The second issue is the new changes to the dataverse header layout, which are still be sorted. Those details can now be tracked in this new issue, Dataverse Header/Theme - New layout, default colors #4197.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants