Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm 5.0 is not a memory hog 🐷, make necessary adjustments #7156

Closed
djbrooke opened this issue Aug 3, 2020 · 5 comments
Closed

Confirm 5.0 is not a memory hog 🐷, make necessary adjustments #7156

djbrooke opened this issue Aug 3, 2020 · 5 comments
Assignees
Milestone

Comments

@djbrooke
Copy link
Contributor

djbrooke commented Aug 3, 2020

In #7089/#7155 we added the ability to run memory tests on the 5.0 release candidate. We should now use this power to see if the release candidate is performing as well or better than 4.20 in terms of memory usage.

@djbrooke djbrooke added this to the Dataverse 5 milestone Aug 3, 2020
@mheppler
Copy link
Contributor

mheppler commented Aug 3, 2020

Duplicate? Run Memory Tests on Release Candidate #7089

@pdurbin pdurbin assigned pdurbin and unassigned pdurbin Aug 3, 2020
@pdurbin
Copy link
Member

pdurbin commented Aug 4, 2020

Per tech hours, @scolapasta will use this issue to coordinate the "human swarm." 🐝 🐝 🐝

#7155 is a good place to follow up on discussion of memory tests.

@pdurbin
Copy link
Member

pdurbin commented Aug 4, 2020

As discussed in tech hours, here are the results of the memory tests. The raw data and more is linked from the "Comparison for memory tests 4.20 vs 5.0 RC" spreadsheet at https://docs.google.com/spreadsheets/d/1Pghs_UIGb1QEmPl01HJ3T9KRvEZy619dp3dJ-2S6gTQ/edit#gid=0

4.20

benchmark-dataset
benchmark-dataverse

4.20-withG1GC

benchmark-dataset
benchmark-dataverse

5.0rc-78527a291

benchmark-dataset
benchmark-dataverse

5.0rc-78527a291-noG1GC

benchmark-dataset
benchmark-dataverse

@scolapasta
Copy link
Contributor

Thanks for the graphs @pdurbin. As we discussed, these results are what we want to see - similar graphs when using the same GC. So for that purpose, these tests "passed".

One more test we still plan on doing is a team "swarm". Once we have the RC ready, we'll set an hour and everyone will go and use the system, create objects, etc. We'll keep this ticket open until we do that.

@scolapasta
Copy link
Contributor

Swarm run. While we found an unrelated issue (with the publish button), nothing memory related jumped out as consequential related to 4.20. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants