Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Browse Dataverse Feature for One's Own Dataverse #750

Closed
eaquigley opened this issue Jul 17, 2014 · 13 comments
Closed

Enable Browse Dataverse Feature for One's Own Dataverse #750

eaquigley opened this issue Jul 17, 2014 · 13 comments
Assignees
Labels
Type: Feature a feature request

Comments

@eaquigley
Copy link
Contributor

1 edit dataverse - browse options
2 browse options modal
3 dataverse with browse options

@sekmiller
Copy link
Contributor

@eaquigley - Is dataverse type going to be required? if not, should there be a link for "untyped" (better term?) dv's or do we ignore them for the purposes of dataverse type?

@eaquigley
Copy link
Contributor Author

@sekmiller definitely think it should be required, agree @posixeleni ? Each dataverse should be able to fall into one of those.

@posixeleni
Copy link
Contributor

@eaquigley I agree that it should be required.

However, do you think we should have a Miscellaneous or Other Dataverse option just in case we are missing a Type? Hard to say we have everything covered for example I just created a Dataverse for datasets that are related to Books that a publisher publishes, which I cant easily assign to the types we have decided on. Any suggestions?

It will also be interesting to see how we add this Type to pre-4.0 Dataverses.

cc/ @sekmiller

@eaquigley
Copy link
Contributor Author

@sekmiller @posixeleni based off quick discussion on 7/21, we've decided to not allow a write in option for a user to add in their Dataverse type if it isn't listed.

@mheppler
Copy link
Contributor

Added initial wire-frame work for Browse Options popup and Featured and Type carousels to the Dataverse page.

Used the Owl Carousel plugin [http://owlgraphic.com/owlcarousel/index.html].

@sekmiller
Copy link
Contributor

Wired up the popup and dataverse page to the extent possible. Still need facets for dv types. @mheppler please fix the dataverse type drop down on the dataverse page.

@sekmiller sekmiller assigned mheppler and unassigned sekmiller Jul 24, 2014
@pdurbin
Copy link
Member

pdurbin commented Jul 28, 2014

Still need facets for dv types

@mheppler I know you may want a separate ticket for this but now I wanted to write down the decision we all just made on how this is supposed to work:

  • When you click a type (e.g. "Journals") or any facet (e.g. "Affiliation"), both carousels should disappear and you should see the normal X above the count of search results to remove the facet (e.g. "Dataverse Type: Journals X").

@mheppler
Copy link
Contributor

Checked in the revisions to the UI for the Browse Options workflow. Here are some notes to review all the features included, and not included:

  • Due to scheduling, we have delayed the "Dataverses by Type" feature, because there is additional work that needs to be done, to index those values.
  • Also, that feature is now labeled as "Dataverses by Category" because we use "Type" to mean Dataverse, Dataset, File.
  • The two carousels and the dataverse description are now hidden when you do a text search, or browse by clicking on a facet. However, clicking on the Dataverse, Dataset, File type facets does not hide it. Phil will need to look into that when we work on the indexing.
  • The left and right chevrons should only display if you have more than 4 dataverses added to that carousel.
  • You can click and drag left/right on the carousel items, to mimic a swiping motion on a tablet or phone.
  • The default dataverse icon is displayed unless a logo is uploaded. In order to do that follow these next steps:
    ** Manually add to the URL, the parameter: editMode=THEME (don't forget the & between that and the id parameter.)
    ** Create a "logos" directory inside your glassfish docroot. Inside there, create a folder named with the id number you are editing the customization for. Put your logo image file in there.
    ** In the form, add the URL to that image, minus "logos" (ie: '22/logo.jpg').
    ** Select the size: Square, Rectangle, and location: Left, Center (only for rectangle), Right.
    ** Save, and you should now see your logo in your dataverse header.

@mheppler mheppler assigned kcondon and unassigned mheppler Jul 30, 2014
@kcondon kcondon removed their assignment Jul 30, 2014
@sekmiller
Copy link
Contributor

As discussed with Kevin this morning, the data verses available to be selected as featured are only the published children of the dv being edited. Response time for loading the page was too slow when even grandchildren were included. Will look into modifying the way dvs are selected for the browse popup.

@mheppler
Copy link
Contributor

Layout issue noticed for error message associated with Type/Category dropdown on edit dataverse.

Please select a type for your dataverse.Please select a type for your dataverse.

Need space between "dataverse" and "Please". Also need to swap those "type"s to "category"s. And maybe make it a little little less less redundant redundant.

@mheppler
Copy link
Contributor

Cleaned up the error message for Browse Options, and fixed an issue with the same error message being repeated twice in the message block.

@mheppler mheppler assigned kcondon and unassigned mheppler Jul 31, 2014
@kcondon
Copy link
Contributor

kcondon commented Aug 6, 2014

Tested as described above. Passing back to Stephen to add dv by type feature.

@eaquigley
Copy link
Contributor Author

Closing this ticket because functionality for featured dvs has been done. Category/Type will be a facet and I've created a ticket for that #956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature a feature request
Projects
None yet
Development

No branches or pull requests

6 participants