Webhook Channel - Validate Request Body Template on save

[martialblog]

Would be cool if invalid Request Body Templates are rejected before using them

Request Body Template: {{ is accepted, but then:

2024-07-25T09:33:45.401Z	ERROR	incident	Failed to send notification via channel plugin	{"object": "icinga.vagrant!SomeURL", "incident": "#17", "type": "webhook", "error": "plugin could not be started"}
2024-07-25T09:33:45.402Z	ERROR	channel	Failed to set channel plugin config, terminating the plugin	{"id": 2, "name": "Captain Hook", "error": "failed to set plugin config: cannot parse Request Body template: template: request_body:1: unclosed action"}

Which only shows up in the logs, when something needs to be sent not before.
There is no way to see my mistakes in the WebUI, which could be helpful when customizing the template.

Also there should be documentation on the template language, it uses Golang's text/template if I'm not mistaken? Should be mentioned in the docs how I can edit the request body.

[julianbrost]

That's limited due to the design of the system, the web frontend just writes the config you entered to the database, it doesn't really have the means to validate that config by itself. Additionally, currently all communication happens over the SQL database, I doubt we would want to implement some kind of RPC to validate config over that. So probably the best we could do here would be to asynchronously show that the channel is in an error state.

@oxzi What are you planning to do here as you assigned it to yourself?

[oxzi]

Tbh, I wasn't planning to assign me for this issue. I must have clicked incorrectly.