Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current line higlighting #2

Open
folixg opened this issue Oct 4, 2018 · 4 comments
Open

Current line higlighting #2

folixg opened this issue Oct 4, 2018 · 4 comments
Assignees
Labels

Comments

@folixg
Copy link

folixg commented Oct 4, 2018

I noticed that the line highlighting in this scheme differs from the original Lucario theme.
I expected the current line to be highlighted with #243443, however the line background is not highlighted at all, instead the line borders have a different color.

This difference can also be seen, when looking at the screenshot provided with this repository and the screenshot provided in the original Lucario repository.

It's not really an issue, since I was able to get the desired behavior by changing the corresponding entries in the JSON, but I was curious, what the reason for this discrepancy is.

@Ikuyadeu
Copy link
Owner

Ikuyadeu commented Oct 4, 2018

@folixg Thank you for your interest.
I generated this color scheme from original set. (Screen shot is this time)
After, I edited based on Dracula for working on VS Code environment.

However, I need fix this theme, and submit a new screenshot to original repository.
Thank you again.

@Ikuyadeu Ikuyadeu added the bug label Oct 4, 2018
@Ikuyadeu Ikuyadeu self-assigned this Oct 4, 2018
@filiptepper
Copy link

@folixg Did you manage to get line highlighting fixed in any way? I just started using Lucario, but that line highlighting is killing all the joy. ;-)

@filiptepper
Copy link

I ended up with this to match Sublime Text:

{
    "workbench.colorCustomizations": {
        "[Lucario]": {
            "editorRuler.foreground": "#4a5a68",
            "editorIndentGuide.background": "#4a5a68",
            "editorWhitespace.foreground": "#4a5a68",
            "editor.lineHighlightBorder": "#253646",
            "editor.lineHighlightBackground": "#253646",
            "editor.selectionBackground": "#253646",
        }
    }
}

@folixg
Copy link
Author

folixg commented Apr 21, 2020

I think I did something similar. However, I stopped using lucario since it appears to be no longer maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants