Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+Alt+* hotkeys doesn't work on non-English keyboard layouts #19

Closed
Infocatcher opened this issue Apr 8, 2013 · 2 comments
Closed
Labels

Comments

@Infocatcher
Copy link
Owner

Unfortunately this is platform "bug".

Example for Ctrl+Alt+V on Russian keyboard layout:
event.charCode: 1084
String.fromCharCode(event.charCode): м
event.keyCode: 0

So we can 1) change default hotkeys to Ctrl+Shift+* or 2) add ability to create many hotkeys for one action.

Infocatcher added a commit that referenced this issue Apr 8, 2013
extensions.privateTab.key.%command_id%#%any_key_name%
(related to #19)
@Infocatcher
Copy link
Owner Author

Reason: https://developer.mozilla.org/en-US/docs/Gecko_Keypress_Event#charCode_of_DOM_keypress_event
So we can use only Ctrl+* and Ctrl+Shift+*. :(

Infocatcher added a commit that referenced this issue Apr 9, 2013
@Infocatcher
Copy link
Owner Author

Explanation

New method:

extensions.privateTab.keysUseKeydownEvent = true
extensions.privateTab.key.openNewPrivateTab = "control alt VK_P"
extensions.privateTab.key.toggleTabPrivate = "control alt VK_V"

To use old method:

extensions.privateTab.keysUseKeydownEvent = false
extensions.privateTab.key.openNewPrivateTab = "control alt p"
extensions.privateTab.key.toggleTabPrivate = "control alt v"

And additional hotkeys for Russian keyboard layout:

extensions.privateTab.key.openNewPrivateTab#ru = "control alt з"
extensions.privateTab.key.toggleTabPrivate#ru = "control alt м"

See also notes in defaults/preferences/prefs.js

Infocatcher added a commit that referenced this issue Sep 17, 2013
Old Ctrl+Alt+V shortcut breaks AltGr+V (due to fix for #19), that used to insert "@" symbol on some keyboard layouts
(closes #105)
Infocatcher added a commit that referenced this issue May 6, 2014
add link to issue #19 about hotkeys on non-Latin keyboard layouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant