Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to comrak's anchorizer #227

Merged

Conversation

CosmicHorrorDev
Copy link
Collaborator

@CosmicHorrorDev CosmicHorrorDev commented Feb 2, 2024

Fixes #204

comrak's anchorizer is a much better fit for a markdown anchorizer than our home-rolled version

Note: (from the docs)

...

To guarantee uniqueness, an anchorizer keeps track of the anchors it has returned. So, for example, to parse several MarkDown files, use a new anchorizer per file.

Resetting the anchorizer is handled by State (which contains the anchorizer) getting reset before each markdown file gets processed

@CosmicHorrorDev CosmicHorrorDev added the C-bug Category: Something isn't working label Feb 2, 2024
@CosmicHorrorDev CosmicHorrorDev merged commit 1fb6611 into Inlyne-Project:main Feb 2, 2024
9 checks passed
@CosmicHorrorDev CosmicHorrorDev deleted the comrak-anchorizer branch February 2, 2024 23:39
@CosmicHorrorDev CosmicHorrorDev added the A-interpreter Area: Changes impacting the HTML interpreter label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-interpreter Area: Changes impacting the HTML interpreter C-bug Category: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to comrak's anchorizer
1 participant