Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScopeJVM.kt has no package #1094

Closed
asapha opened this issue May 17, 2021 · 1 comment
Closed

ScopeJVM.kt has no package #1094

asapha opened this issue May 17, 2021 · 1 comment
Labels
Milestone

Comments

@asapha
Copy link

asapha commented May 17, 2021

Describe the bug
ScopeJVM.kt has no package entry.
When using Java 9 Modules with koin 3.0.1, this error is raised:

java.lang.module.FindException: Unable to derive module descriptor for [...]/koin-core-jvm-3.0.1.jar
Caused by: java.lang.module.InvalidModuleDescriptorException: ScopeJVMKt.class found in top-level directory (unnamed package not allowed in module)

To Reproduce
Add requires koin.core.jvm; to a module-info.java file

Expected behavior
ScopeJVM.kt should probably have package org.koin.core.scope .

Koin project used and used version (please complete the following information):
koin-core version 3.0.1

@arnaudgiuliani arnaudgiuliani added this to the 3.0.3 milestone May 24, 2021
@arnaudgiuliani
Copy link
Member

Fixed on master - 9ed06ff50e788e637bacd362daa41d252309b77f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants