Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixit upgrade makes incomplete fix, second run results in metadata error #406

Open
amyreese opened this issue Nov 9, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@amyreese
Copy link
Member

amyreese commented Nov 9, 2023

from fixit import CstLintRule

class FooRule(CstLintRule):
    ...
Traceback (most recent call last):
  File ../fixit/upgrade/remove_rule_suffix.py", line 58, in visit_ClassDef
    qname = metadata.pop().name
KeyError: 'pop from an empty set'
@amyreese amyreese self-assigned this Nov 9, 2023
@amyreese amyreese added the bug Something isn't working label Nov 9, 2023
@zsol
Copy link
Member

zsol commented Nov 9, 2023

Hmm, metadata should never be mutated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants