Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Glob Patterns in [[tool.fixit.overrides]] #408

Open
max-muoto opened this issue Nov 15, 2023 · 2 comments
Open

Support Glob Patterns in [[tool.fixit.overrides]] #408

max-muoto opened this issue Nov 15, 2023 · 2 comments
Labels
enhancement New feature or request
Milestone
2.x

Comments

@max-muoto
Copy link
Contributor

It would be convenient to utilize glob patterns when specifying path for [[tool.fixit.overrides]]. For example, I might want to disable a rule for all of my tests:

[[tool.fixit.overrides]]
path = "**/tests/**/*.py"
disable = ["fixit.rules:MyRule"]
@max-muoto
Copy link
Contributor Author

Happy to take a stab at this myself as well.

@amyreese amyreese added the enhancement New feature or request label Nov 15, 2023
@amyreese
Copy link
Member

I do think this would be useful and welcome. If you're interested, I think this could be as simple as adding a call to fnmatch() near https://github.com/Instagram/Fixit/blob/main/src/fixit/config.py#L407 as well as some extra tests to cover the functionality.

@amyreese amyreese mentioned this issue Jan 12, 2024
Open
@amyreese amyreese added this to the 2.x milestone Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.x
Development

No branches or pull requests
2 participants
@amyreese @max-muoto