-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile cannot be built with Ubuntu 23.10 #12302
Comments
Hi @cngzhnp The most recent Ubuntu version currently supported by the librealsense SDK is 22.04. It is possible to build librealsense from source code with CMake for non-supported Linux versions by including the flag -DFORCE_RSUSB_BACKEND=TRUE in the CMake build instruction. An RSUSB build of the SDK is not dependent on Linux versions or kernel versions and does not need the kernel to be patched. An example of instructions for performing an RSUSB build from source code can be found at #9931 (comment) |
Hi @MartyG-RealSense, thanks for your answer. However, I do not use anything else than Dockerfile in the scripts folder for build. Only change I did was, upgrading Ubuntu version from 20.04 to 23.10. In my opinion, with new compiler that comes from newer Ubuntu can find more problems in the codebase. Simply, missing header file for uint64_t data type which is not included on version.h. Only this would be enough for fixing right now, I guess. If you say that, third-party library is not managed by you, please let me know. I will try to contact corresponding person. |
This error has not been previously reported in relation to librealsense installation, though it has appeared in a number of non-RealSense cases. In a lot of those cases, a common factor is that GCC 13 is being used. Are you using GCC 13, please? |
Yes, I am using |
I will highlight this issue to my Intel RealSense colleagues. Thanks very much for your patience! |
Hi @cngzhnp Thanks very much for your patience. I had a response from my Intel RealSense colleagues (below). Including This is compiled within Docker. The advice from my colleagues adds that whilst you are using the latest software such as Ubuntu 23.10, it is best to use the versions that are currently supported by librealsense. |
Thanks for the reply @MartyG-RealSense. Do you plan when this fix will be merged into main branch? Adding one necessary header file, does not affect on current behavior, IMHO. |
I have enquired to my colleagues about your question above regarding whether the change will be added to the master branch. |
Hi @cngzhnp Do you require further assistance with this case, please? Thanks! |
Hello @MartyG-RealSense, no thanks a lot. Only one more thing, do you have any plan when it will be merged into main and when you do release a new version? |
I have contacted my Intel RealSense colleagues regarding whether there is a time estimate available for the next master release. I will let you know as soon as I have a reply. |
Hi @cngzhnp As the GCC fix has been merged ito the master branch (see the comment above), do you require further assistance with this case please? Thanks! |
Hello @MartyG-RealSense, Thanks for your fast & informative support. IMHO, we can live this change right now. No required any further assistance. Best Regards. |
You are very welcome. I'm pleased that I could help. Thanks very much for the update! |
Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):
All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)
Issue Description
When Ubuntu 23.10 base image is used to compile 2.54.2 version, there is a compilation error which could be seen below:
#0 6.140 /usr/src/librealsense/third-party/rsutils/include/rsutils/version.h:23:13: error: 'uint64_t' does not name a type
#0 6.140 23 | typedef uint64_t number_type;
#0 6.140 | ^~~~~~~~
#0 6.140 /usr/src/librealsense/third-party/rsutils/include/rsutils/version.h:7:1: note: 'uint64_t' is defined in header ''; did you forget to '#include '?
In this header file, actually uint64_t requires system header file and it is missing.
The text was updated successfully, but these errors were encountered: