Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# wrapper introduces a dependency on the full .NET Framework #3419

Closed
jcannata opened this issue Mar 7, 2019 · 4 comments
Closed

C# wrapper introduces a dependency on the full .NET Framework #3419

jcannata opened this issue Mar 7, 2019 · 4 comments
Labels

Comments

@jcannata
Copy link

jcannata commented Mar 7, 2019

Required Info
Camera Model n/a
Firmware Version n/a
Operating System & Version {Win (8.1/10) / Linux (Ubuntu 14/16/17) / MacOS
Kernel Version (Linux Only) n/a
Platform PC
SDK Version 2.19.0
Language C#
Segment n/a

Issue Description

Out software project targets .NET Core so any referenced libraries must be .NET Standard 2.0 compatible.
A recent modification to NativeMethods.cs (45eb153) to support portable memory copy has introduced a dependency on the full .NET Framework. Previously the wrapper was .NET Standard 2.0 compatible but the class System.Reflection.Emit.DynamicMethod is not part of the standard. It appears that the code is trying to support an unknown O/S (i.e. not Windows, Linux or MacOSX). Is there another way to do this?

@dorodnic
Copy link
Contributor

dorodnic commented Mar 7, 2019

Hi @jcannata
Thanks for raising this. @ogoshen - when would we be hitting the CpBlk branch?

@dorodnic dorodnic added the .NET label Mar 7, 2019
@ogoshen
Copy link
Contributor

ogoshen commented Mar 10, 2019

Right, the package isn't part of core, but it is supported.
I've tested it to work on .NET Core 2.0 with dotnet add package System.Reflection.Emit

But I see no problem in removing it and supporting .NET Standard 2.0, I'll just throw a PlatformNotSupportedException instead.

@RealSenseCustomerSupport
Copy link
Collaborator


Hi jcannata,

Given what ogoshen commented, do you still need help on this one?

Thanks!

@jcannata
Copy link
Author

jcannata commented Apr 9, 2019

No, thank you.

@jcannata jcannata closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants