Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Decompiler will print general hero settings in the wrong group. #239

Open
gabehxd opened this issue Dec 10, 2020 · 3 comments
Open
Labels
bug Something isn't working decompiler Decompiling workshop code to OSTW code lobby settings Missing or incorrect lobby settings question Further information is requested

Comments

@gabehxd
Copy link

gabehxd commented Dec 10, 2020

image
image
This is was created from the decompiler using v2 B.

@ItsDeltin ItsDeltin added bug Something isn't working lobby settings Missing or incorrect lobby settings labels Dec 10, 2020
@ItsDeltin
Copy link
Owner

Should be:

"General": {
    "General": {
        "Movement Speed": 120.0
    },
    "Ana": {
        ...
    }
},
"Team 1": {
}

The first 'General' is the team, the second 'General' is the general hero settings.
I can see how this is counter-intuitive, I'm open to moving the general hero settings to the parent section or renaming the first one to 'All Teams'

@ItsDeltin ItsDeltin added question Further information is requested and removed bug Something isn't working labels Dec 10, 2020
@gabehxd
Copy link
Author

gabehxd commented Dec 10, 2020

I can move it for my project but I think this should be updated so it does fall in line with what the decompiler outputs which the screenshots are a copy of.

@ItsDeltin ItsDeltin added the bug Something isn't working label Dec 10, 2020
@ItsDeltin ItsDeltin changed the title [Bug] Movement Speed is not recognized in customGameSettings and does not compiled when imported [Bug] Decompiler will print general hero settings in the wrong group. Dec 30, 2020
@ItsDeltin ItsDeltin added the decompiler Decompiling workshop code to OSTW code label Dec 30, 2020
@ItsDeltin ItsDeltin pinned this issue Dec 30, 2020
@CactusPuppy
Copy link
Collaborator

The decompiler outputs general hero settings in the first General level, which is not currently supported by the compiler (v2-beta.14)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working decompiler Decompiling workshop code to OSTW code lobby settings Missing or incorrect lobby settings question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants