Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "local" orphan impls that only affect behavior within your own crate #13

Open
Ixrec opened this issue Jul 7, 2018 · 1 comment

Comments

@Ixrec
Copy link
Owner

Ixrec commented Jul 7, 2018

Keeping the impls local would prevent the problems with actually embracing incoherence. But that is a very strong restriction, so it's not clear to me is whether there are any use cases that would a) actually be solved by this, and b) would not be better off with a newtype.

@Ixrec
Copy link
Owner Author

Ixrec commented Jul 7, 2018

This appears to be what https://internals.rust-lang.org/t/revisit-orphan-rules/7795 and https://internals.rust-lang.org/t/thoughts-on-pub-impl/7819 are proposing, though it's not entirely clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant