Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synadm support for Synapse over a Unix socket #151

Open
JacksonChen666 opened this issue Aug 14, 2024 · 2 comments
Open

synadm support for Synapse over a Unix socket #151

JacksonChen666 opened this issue Aug 14, 2024 · 2 comments
Labels
feature Feature request, not a core feature

Comments

@JacksonChen666
Copy link
Collaborator

JacksonChen666 commented Aug 14, 2024

Synapse supports listening over a Unix socket. The library synadm uses to make HTTP requests is requests (python) (pretty much the requests part of synadm), which doesn't appear to support Unix sockets (https://stackoverflow.com/questions/26964595/whats-the-correct-way-to-use-a-unix-domain-socket-in-requests-framework/#27268999), so synadm doesn't support Synapse installs which listen over a Unix socket.

Some things to consider when implementing: The configurator (ask for http or unix, or try to interpret via some unix:// thing instead (handling URIs doesn't seem fun)), how synadm deals with library switeroo (and adding a dependency (plus distributions packaging synadm (although that might be a problem for distributions and not necessarily us)))

@JacksonChen666 JacksonChen666 added the feature Feature request, not a core feature label Aug 14, 2024
@JacksonChen666
Copy link
Collaborator Author

(Re: Feature/Core feature label: I'm not sure if this should be considered a core feature, and so just made it a normal feature label)

@JacksonChen666
Copy link
Collaborator Author

Another thing to consider is workers (which handle specific points sometimes e.g. media), but I'm not sure how that should be handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request, not a core feature
Projects
None yet
Development

No branches or pull requests

1 participant