Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept MXC URIs for syandm media quarantine #152

Open
JacksonChen666 opened this issue Sep 6, 2024 · 2 comments
Open

Accept MXC URIs for syandm media quarantine #152

JacksonChen666 opened this issue Sep 6, 2024 · 2 comments
Labels
feature Feature request, not a core feature

Comments

@JacksonChen666
Copy link
Collaborator

For example: syandm media quarantine mxc://example.com/INSERT_MEDIA_ID_HERE

This would make it much easier than having to split things apart manually and turn the command into synadm media quarantine --media-id INSERT_MEDIA_ID_HERE --server-name example.com which is somewhat more tricky to remember (it's -i for media and -s for server name)

Also apply on all other media commands (where MXC URI makes sense) like unquarantine and... nothing else?

@JacksonChen666 JacksonChen666 added the feature Feature request, not a core feature label Sep 6, 2024
@JOJ0
Copy link
Owner

JOJ0 commented Sep 10, 2024

definitely a good idea! Been there done that! Just copying the URI from the synadm media list command would be so much easier.

Just wanted to note that for local media you would not require to add --server-name since that is either auto-retrieved or fetched from config.yaml, which leaves you with a slightly simpler command:

synadm media quarantine -i <MEDIA_ID>

Sorry for asking a dumb question, I'm not sure anymore: Can media from remote servers also be quarantined?

@JacksonChen666
Copy link
Collaborator Author

Sorry for asking a dumb question, I'm not sure anymore: Can media from remote servers also be quarantined?

That was what I was about to say: Yes, remote media is applicable

Quarantining media means that it is marked as inaccessible by users. It applies to any local media, and any locally-cached copies of remote media.

(https://element-hq.github.io/synapse/latest/admin_api/media_admin_api.html#quarantine-media)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request, not a core feature
Projects
None yet
Development

No branches or pull requests

2 participants