Some RefBy fields have duplicate references

[bmaclach]

I noticed while updating SSP that sometimes Refby fields list the same references multiple times:

In this case, the listed IMs each reference this GD multiple times in their definitions, and these duplicate references are not being filtered out any time before rendering the RefBy field.

[JacquesCarette]

Yep, must be a nub missing somewhere. I'll likely start digging into the code again in May.

[smiths]

Good catch @bmaclach.

[Awurama-N]

@JacquesCarette please could you elaborate a bit on what you meant by a missing nub somewhere? so i could look in the right places to fix this bug.

[JacquesCarette]

nub is a standard Haskell function which removes duplicate elements from a list.

[hrzhuang]

I am not seeing this duplication in the SSP SRS. I think this has been resolved at some point?

[JacquesCarette]

It quite likely has. It would still be worth looking if it is accidentally fixed or if someone put in a call to nub somewhere appropriate.

[hrzhuang]

I found the fix for this in 5adb76b. The commit message, the fact that nub was added, and the changes to stable all check out. I think we can close this issue.

[balacij]

Nice, thank you @hrzhuang. We can re-open this if we find another case.