Requirements not Reused between SWHS and NoPCM

[samm82]

(Came from working on #1229 and #1276)

There are a lot of similar (almost) identical functional requirements that are defined individually in SWHS and NoPCM and should be reused. There are also some discrepancies from the manual, as described in #439 that should be fixed in both examples (if/when applicable).

TODO

In branch swhsNoPCMReqs

• Input-Initial-Quantities
  • Move assumption from Input-Initial-Quantities to Find-Mass
  • Add quantities to table (Add Missing Quantities to FR1 Table in SWHS/NoPCM #1307)
• Find-Mass
  • Add "^2" to equation
  • Add "pi" to equation (Missing pi Symbol in SWHS/NoPCM FR2 #1308)
• Check-Input-with-Physical_Constraints
• Output-Input-Derived-Quantities
• Calculate-Temperature-Water-Over-Time
• Calculate-Change-Heat_Energy-Water-Over-Time
• Move NoPCM requirements to separate file

[samm82]

@smiths Is the assumption here (in the first FR of SWHS) really necessary? This FR only deals with inputting the values, and this assumption seems to apply more to calculations. This assumption and its reference aren't in NoPCM.

[samm82]

@smiths Also, the table in Drasil for FR1 is missing these quantities:

[samm82]

(I think I should have kept #439 open 😬)

@smiths This equation is wrong in Drasil:

This could be an example of what we discussed in our meeting; it doesn't look like Drasil knows about the volume formula for a cylinder.

[smiths]

@samm82, try to keep one topic per issue. It makes it easier to address your questions, and it should lead to closing the easy issue quickly.

For your first sub-issue (unnecessary assumption), if you look at the manual case study (https://github.com/smiths/swhs/blob/master/docs/SRS/PCM_SRS.pdf) you will see that a mistake was made in translating from manual to Drasil. It is really a shame that mistakes like this are still cropping up. 😞 The assumption that the volume is negligible goes with the Find-Mass requirement. If you look at the derivation it assumes that the mass of the water is based on the volume of the water, which is calculated from the volume of the tank, minus the volume of the PCM. Technically the coil volume should also be subtracted, but the assumption means that we can ignore this. Please move the assumption to be with the correct requirement.

For your second sub-issue, you should add the missing inputs to the table of input variables.

For your third sub-issue, you are also correct that Drasil has the wrong formula. I think this is just a mistake with someone entering the formulae. I don't believe we have "taught" Drasil the volume formulas yet.