Catch undesired intersection between fields of SystemInformation #1506
Labels
design
Related to the current design of Drasil (not artifacts).
needs-clarification
Needs a clear 'state', 'goal', 'analysis', and 'explanation' to reduce solution ambiguities.
needs-design
Some fields in
SystemInformation
are intended to be disjoint. For example, if the same equation is included in thedefinitions
field and thedatadefs
field, the function corresponding to that calculation will be duplicated in the generated code. Theinputs
andoutputs
field should also be disjoint (though we currently include the outputs in the inputs in many examples as a hack for when we can't express all of the equations necessary for calculating the outputs).Drasil should perform a check that these fields are actually disjoint.
Note: There is a FIXME in the code saying that the
definitions
field will be removed in the future.Drasil/code/drasil-database/Database/Drasil/SystemInformation.hs
Lines 32 to 33 in a75925c
I'm thinking it will need to be replaced by something else so we don't lose the information it contained (the
GenDefn
s andInstanceModel
s), in which case we will still need to check that none of theDataDefinition
s,GenDefn
s, orInstanceModel
s are the same.The text was updated successfully, but these errors were encountered: