Error in SWHS Output Constraint

[JacquesCarette]

While working on issue #1030 I noticed an error in the output constraint of SWHS (https://jacquescarette.github.io/Drasil/examples/SWHS/srs/SWHS_SRS.html#IM:eBalanceOnWtr) for one of the IMs.

The point is that the output is the function T_W while the constraint is on time t, which isn't part of the output.

That 'constraint' is really part of the type of T_W (its domain).

This 'bug' appears to be present in other Instance Models too.

[JacquesCarette]

I have removed this constraint (and 4 more like it). They are not output constraints. They are type constraints on (here) T_W, as it is a function (of time) rather than a constant. Our modelling of functions, especially of time, is extremely sloppy.

This occurs 3 times in SWHS and once in NoPCM.

[smiths]

@JacquesCarette, I agree with the removal. The constraint on t wasn't anywhere in the manual version of the case studies. It doesn't make sense to include it as an output constraint here, because t is not an output. I agree that our handling of types is sloppy.

I think we can close this issue. It is assigned to me, but I don't see anything else that needs to be done.

Rather than consider T_W a real number, it would be great if we could consider it a function from real to real. I think we already have issues that deal with improving our use of types in Drasil.