Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from using String in Data Table Generator #2210

Closed
Nathaniel-Hu opened this issue Jul 15, 2020 · 1 comment
Closed

Switch from using String in Data Table Generator #2210

Nathaniel-Hu opened this issue Jul 15, 2020 · 1 comment
Labels
enhancement

Comments

@Nathaniel-Hu
Copy link
Collaborator

Nathaniel-Hu commented Jul 15, 2020 •
edited
Loading

Based upon discussions in Issue #2095, the Data Table Generator will most likely move away from using the String type to another faster, more space-efficient type (likely the ByteString type).

However, a re-investigation (as per @JacquesCarette's request) should likely take place to determine the best "state of the practice" before committing to a change. Maybe look among alternatives to find the best choice type.

Note: the current version of the Data Table Generator (in /scripts/) is currently contained in this branch, and is awaiting merge approval in this pull request.
Note: pull request has been merged.
@balacij
Copy link
Collaborator

balacij commented Apr 27, 2023

Closing in favour of #2606. As always, if anyone feels otherwise, please re-open.

@balacij balacij closed this as completed Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@balacij @Nathaniel-Hu