Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge addRe and addI, and mulI and mulRe #3153

Closed
balacij opened this issue Nov 28, 2022 · 1 comment · Fixed by #3812
Closed

Merge addRe and addI, and mulI and mulRe #3153

balacij opened this issue Nov 28, 2022 · 1 comment · Fixed by #3812
Assignees
Labels
easy At quick glance, it should be 'easy,' but you never know what'll happen! enhancement

Comments

@balacij
Copy link
Collaborator

balacij commented Nov 28, 2022

    I agree about merging `addRe` and `addI` and hiding.

    The errors are real (pun intended) basically because none of those things should be `Rational`, that seems like a plain hack that should be fixed.

Originally posted by @JacquesCarette in #3131 (comment)

@balacij balacij self-assigned this Nov 28, 2022
@balacij balacij added enhancement easy At quick glance, it should be 'easy,' but you never know what'll happen! labels May 4, 2023
@daijingz
Copy link
Contributor

@balacij Jason, I want to work on this issue. Although previously I did not do any difficult questions. I want to have a try.

The code is at \code\drasil-lang\lib\Language\Drasil\Expr\Class.hs
@LR5 3D5F$BOTHQ5D$SQXW6

In my opinion, the first part we need to do is check whether both function types are compatible or not. However, both functions have arbitrary types, so I need to check other function callings first.
H_CBJM4%EPKQJ9MVWE5 QVK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy At quick glance, it should be 'easy,' but you never know what'll happen! enhancement
Projects
None yet
4 participants