PD Controller example is labelled as "PD_Controller" instead of "PDController" on website

[samm82]

I noticed this before but waited in case #3521 fixed this. The PD Controller example is called exactly that, space included:

Drasil/code/drasil-example/pdcontroller/lib/Drasil/PDController/Concepts.hs

Line 17 in 8d5e8f8

pdControllerApp = commonIdeaWithDict "pdControllerApp" (pn "PD Controller") "PD Controller" []

However, it seems that on the website, this space is replaced with an underscore instead of just being omitted:

A consequence of this is that the links generated are incorrect:

Removing these underscores from the URL leads to the correct page:

Since this is the only example name with a space, I think there is likely a function that gets called at some point that replaces spaces with underscores, when they should just be omitted (at least in the use case of the website).

[smiths]

Good catch @samm82. We should definitely fix this.

[JacquesCarette]

I think pn should give a hard error if the "proper noun" being given has some forbidden characters in it.

[balacij]

Off-topic: should the acronym for PD Controller instead be PDC? PD Controller seems to break continuity with the 'normal' acronym naming scheme.

[smiths]

I think we'll have a tough time coming up with consistent acronym rules. The people in the field talk about PID controllers and PD controllers. They don't say PDC. In this case, it is more important that we follow the conventions of the community.

[balacij]

That makes sense. Thank you, @smiths!

Regarding the issue, the problem area is obvious enough, but a proper solution isn't quite clear. The problem has to do with programName usage. Hopefully I'll figure it out tomorrow.