Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove iterators from MethodState #3919

Closed
B-rando1 opened this issue Aug 9, 2024 · 1 comment · Fixed by #3938
Closed

Remove iterators from MethodState #3919

B-rando1 opened this issue Aug 9, 2024 · 1 comment · Fixed by #3938
Assignees
@B-rando1 @NoahCardoso
Labels
easy At quick glance, it should be 'easy,' but you never know what'll happen!

Comments

@B-rando1
Copy link
Collaborator

B-rando1 commented Aug 9, 2024

As we found in a discussion in #3878, the iterators field in MethodState will be unused once that PR is merged. It is currently only used in one place in the C++ renderer, and @NoahCardoso changed the implementation so that it is no longer needed there.

Once #3878 is passed, we should do a quick double-check that iterators isn't used anywhere else; then we should be safe to remove it.
@B-rando1 B-rando1 added the easy At quick glance, it should be 'easy,' but you never know what'll happen! label Aug 9, 2024
@NoahCardoso NoahCardoso mentioned this issue Aug 9, 2024
Open
@NoahCardoso
Copy link
Collaborator

I fixed this issue. Once Sets gets merged I will make a pr for this.

This was referenced Aug 19, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@B-rando1 B-rando1

@NoahCardoso NoahCardoso

Labels
easy At quick glance, it should be 'easy,' but you never know what'll happen!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed iterators from MethodState JacquesCarette/Drasil
2 participants
@B-rando1 @NoahCardoso