Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of DatePicker/Calendar widget. #1299

Closed
dnrusakov opened this issue Oct 24, 2021 · 13 comments · Fixed by JetBrains/compose-multiplatform-core#717
Closed

Add support of DatePicker/Calendar widget. #1299

dnrusakov opened this issue Oct 24, 2021 · 13 comments · Fixed by JetBrains/compose-multiplatform-core#717
Assignees
Labels
desktop enhancement New feature or request

Comments

@dnrusakov
Copy link

As I understand there is no a DatePicker/Calendar widget right now in Jetpack compose for Desktop. At the same time it is extremely widespread use case appeared in numerous modern interfaces.
Could you guys, please, add one to Jetpack compose for Desktop?
Thank you!

@christoph-grimm
Copy link

I think current focus is on creating the basic framework that enables composables.

@darvld
Copy link

darvld commented Oct 24, 2021

From similar issues in the past, I would say this is simply out of the scope of the framework, and should be left to individual libraries/components (like Accompanist for Jetpack Compose).

@dnrusakov
Copy link
Author

Why Button widget is not left for other libraries but DatePicker is? DatePicker is pretty much as widespread as the regular buttons.

@olonho
Copy link
Contributor

olonho commented Oct 25, 2021

We may provide such functionality, but not immediately, especially as there are quite a few existing pickers like https://github.com/LGoodDatePicker/LGoodDatePicker that could be easily interoped with. Also this kind of component is what we'll happily accept (presuming decent quality and tests) as a component in https://github.com/JetBrains/compose-jb/tree/master/components

@dnrusakov
Copy link
Author

@olonho Thank you!

@helmysaeed
Copy link

As I understand there is no a DatePicker/Calendar widget right now in Jetpack compose for Desktop. At the same time it is extremely widespread use case appeared in numerous modern interfaces. Could you guys, please, add one to Jetpack compose for Desktop? Thank you!

it's very important widget

@lazaroofarrill
Copy link

As I understand there is no a DatePicker/Calendar widget right now in Jetpack compose for Desktop. At the same time it is extremely widespread use case appeared in numerous modern interfaces. Could you guys, please, add one to Jetpack compose for Desktop? Thank you!

it's very important widget

Like @olonho said using LGoodDatePicker in compose is extremely easy and will work wonderfully for most desktop apps. The team would better expend their time making the core framework more powerful, which in turn will make easier for the rest of us build our own components, rather than making some materialish hard to customize date picker.

@igordmn igordmn removed the Saved label Nov 11, 2022
@hfeky
Copy link

hfeky commented Feb 20, 2023

Are there any plans on when the material date picker will be implemented? I agree it's also very important for desktop apps.

@fflopsi
Copy link

fflopsi commented Jun 12, 2023

#3256 seems to address the bigger issue of the version of Material 3 being 1.0.1, while version 1.1.0 supports date picker composables.

@lazaroofarrill
Copy link

Bumping up the material version won't automatically give you a component that depends on platform specific code. It shouldn't take you that long to implement the widget yourself if you really belief the material date picker fits a desktop application, but as someone said earlier is hard to justify something like this being part of the framework.

@serandel
Copy link

Hard disagree, @lazaroofarrill. Compose for Desktop already supports that library, just an older version. So I expect it contains no platform-specific code, but standard Compose.

@erdevasconcellos
Copy link

[es] Mi implementación de DatePicker en un único archivo Kotlin, sin librerías externas. Probado en un proyecto personal en Compose Desktop.

[en] My DatePicker implementation in a single Kotlin-file, without external libraries or dependencies. Tested in a Compose Desktop project.

https://gist.github.com/erdevasconcellos/8d38a6124b27151f87bdbb4edf4e5cf3

@okushnikov
Copy link
Collaborator

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop enhancement New feature or request
Projects
None yet