From 91a369137df03d255cf25894839c787ce9ce7785 Mon Sep 17 00:00:00 2001
From: Junjie Gao <junjiegao@microsoft.com>
Date: Thu, 3 Aug 2023 20:11:28 +0800
Subject: [PATCH] fix: create pointer instead of value to improve performance

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
---
 internal/encoding/asn1/asn1.go | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/internal/encoding/asn1/asn1.go b/internal/encoding/asn1/asn1.go
index b61863c0..617119b9 100644
--- a/internal/encoding/asn1/asn1.go
+++ b/internal/encoding/asn1/asn1.go
@@ -71,19 +71,19 @@ func decode(r []byte) (value, error) {
 
 	// primitive value
 	if isPrimitive(identifier) {
-		return primitiveValue{
+		return &primitiveValue{
 			identifier: identifier,
 			content:    r[:contentLen],
 		}, nil
 	}
 	// constructed value
-	rootConstructed := constructedValue{
+	rootConstructed := &constructedValue{
 		identifier: identifier,
 		rawContent: r[:contentLen],
 	}
 
 	// start depth-first decoding with stack
-	valueStack := []*constructedValue{&rootConstructed}
+	valueStack := []*constructedValue{rootConstructed}
 	for len(valueStack) > 0 {
 		stackLen := len(valueStack)
 		// top
@@ -110,21 +110,21 @@ func decode(r []byte) (value, error) {
 		}
 		if isPrimitive(identifier) {
 			// primitive value
-			primitiveNode := primitiveValue{
+			primitiveNode := &primitiveValue{
 				identifier: identifier,
 				content:    node.rawContent[:contentLen],
 			}
-			node.members = append(node.members, &primitiveNode)
+			node.members = append(node.members, primitiveNode)
 		} else {
 			// constructed value
-			constructedNode := constructedValue{
+			constructedNode := &constructedValue{
 				identifier: identifier,
 				rawContent: node.rawContent[:contentLen],
 			}
-			node.members = append(node.members, &constructedNode)
+			node.members = append(node.members, constructedNode)
 
 			// add a new constructed node to the stack
-			valueStack = append(valueStack, &constructedNode)
+			valueStack = append(valueStack, constructedNode)
 		}
 		node.rawContent = node.rawContent[contentLen:]
 	}